Skip to content

transition project to webpack#21

Open
andigan wants to merge 1 commit into
masterfrom
transition-to-webpack
Open

transition project to webpack#21
andigan wants to merge 1 commit into
masterfrom
transition-to-webpack

Conversation

@andigan

@andigan andigan commented Feb 3, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .babelrc
@@ -0,0 +1,8 @@
{
"plugins": [ ["transform-decorators"],
["transform-object-rest-spread", {"useBuiltIns": true}]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Comment thread src/evolution.js

export default class Evolution {
constructor() {
console.log('Evolution class created.')

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove log

Comment thread src/evolution.js
var addPlayerstoGame = function(player_names) {
Evolution.addPlayerstoGame = function(player_names) {
// for each player name...
player_names.forEach (function(name) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: arrow function

Comment thread src/prompt.js
this.render = function(dialog, func){
this.render = function(dialog, Evolution){

var dialogoverlay = document.getElementById('dialogoverlay');

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants