Add KalmanFilter for rmoss_util#44
Open
baiyeweiguang wants to merge 10 commits intorobomaster-oss:humblefrom
Open
Add KalmanFilter for rmoss_util#44baiyeweiguang wants to merge 10 commits intorobomaster-oss:humblefrom
baiyeweiguang wants to merge 10 commits intorobomaster-oss:humblefrom
Conversation
Contributor
baiyeweiguang
commented
Jul 22, 2024
- 修改了rmoss_util文件结构,分为common和math两个模块
- 参考ADEKF、rm.cv.fans等开源实现了自动求Jacobian的扩展卡尔曼滤波器,但是引入了新依赖Ceres
- 由于依赖的增加,修改了.github/workflows/ci.yml
Ericsii
requested changes
Jul 22, 2024
| with: | ||
| fetch-depth: 0 | ||
| - name: Pre install | ||
| run: | |
Contributor
Author
There was a problem hiding this comment.
ros-ci会运行rosdep install命令,但似乎不能正确安装libceres-dev
gezp
requested changes
Jul 22, 2024
Member
gezp
left a comment
There was a problem hiding this comment.
可以增加math目录层级,但是你这样的增加方式感觉有点怪,建议如下层级:
- rmoss_util
- include/rmoss_util/math/extended_kalman_filter.hpp
- src
Contributor
Author
不加math目录主要是考虑contrib那里的包用到了原来的util里的东西,如果加了math那common也要加,这样还得改对应的路径 |
Member
common目录没必要加,其他代码可以不动,只给extended_kalman_filter.hpp加一级math就行,像这样
rmoss_contrib准备archive了,也可以先不管它。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.