Skip to content

chore(zero-cache): extra tracing inside processBatch#5722

Merged
tantaman merged 5 commits intomainfrom
mlaw/proc-batch-logging
Apr 6, 2026
Merged

chore(zero-cache): extra tracing inside processBatch#5722
tantaman merged 5 commits intomainfrom
mlaw/proc-batch-logging

Conversation

@tantaman
Copy link
Copy Markdown
Contributor

To determine if flushing to the client is what is consuming all the time

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
replicache-docs Ready Ready Preview, Comment Apr 6, 2026 2:22pm
zbugs Ready Ready Preview, Comment Apr 6, 2026 2:22pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

🐰 Bencher Report

Branchmlaw/proc-batch-logging
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,946.99 KB
(+0.03%)Baseline: 1,946.44 KB
1,985.37 KB
(98.07%)
zero.js📈 view plot
🚷 view threshold
269.32 KB
(0.00%)Baseline: 269.32 KB
274.71 KB
(98.04%)
zero.js.br📈 view plot
🚷 view threshold
71.30 KB
(0.00%)Baseline: 71.30 KB
72.73 KB
(98.04%)
🐰 View full continuous benchmarking report in Bencher

Copy link
Copy Markdown
Contributor

@darkgnotic darkgnotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place that might be useful is any time we await the row records in the CVR updater:

const existingRows = await this._cvrStore.getRowRecords();

It's usually cached but the first CVR update may need to wait on the load, depending on the timing.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

🐰 Bencher Report

Branchmlaw/proc-batch-logging
Testbedself-hosted-metal
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
src/db/pg-copy.bench.ts > pg-copy benchmark > copy📈 view plot
🚷 view threshold
24.30 ops/s
(+2.39%)Baseline: 23.73 ops/s
20.17 ops/s
(83.02%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

🐰 Bencher Report

Branchmlaw/proc-batch-logging
Testbedself-hosted-metal
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
src/client/custom.bench.ts > big schema📈 view plot
🚷 view threshold
104,456.97 ops/s
(-4.06%)Baseline: 108,874.72 ops/s
96,786.42 ops/s
(92.66%)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
1,272.03 ops/s
(-8.71%)Baseline: 1,393.43 ops/s
683.21 ops/s
(53.71%)
src/client/zero.bench.ts > pk compare > pk = N📈 view plot
🚷 view threshold
35,389.40 ops/s
(-7.97%)Baseline: 38,452.36 ops/s
24,812.25 ops/s
(70.11%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
2,042.08 ops/s
(-7.33%)Baseline: 2,203.72 ops/s
1,197.27 ops/s
(58.63%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

🐰 Bencher Report

Branchmlaw/proc-batch-logging
Testbedself-hosted-metal
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
src/size-of-value.bench.ts > getSizeOfValue performance > arrays > large array (100 items)📈 view plot
🚷 view threshold
1,515,523.70 ops/s
(+1.38%)Baseline: 1,494,931.36 ops/s
1,364,531.40 ops/s
(90.04%)
src/size-of-value.bench.ts > getSizeOfValue performance > arrays > small array (10 items)📈 view plot
🚷 view threshold
12,615,188.86 ops/s
(+1.90%)Baseline: 12,379,534.90 ops/s
10,899,886.11 ops/s
(86.40%)
src/size-of-value.bench.ts > getSizeOfValue performance > datasets > large dataset (100x512B)📈 view plot
🚷 view threshold
39,029.19 ops/s
(+2.73%)Baseline: 37,991.03 ops/s
33,920.63 ops/s
(86.91%)
src/size-of-value.bench.ts > getSizeOfValue performance > datasets > small dataset (10x256B)📈 view plot
🚷 view threshold
389,675.22 ops/s
(+1.18%)Baseline: 385,120.15 ops/s
341,167.10 ops/s
(87.55%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > nested object📈 view plot
🚷 view threshold
3,364,917.58 ops/s
(+1.38%)Baseline: 3,318,979.97 ops/s
2,976,992.48 ops/s
(88.47%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (1KB)📈 view plot
🚷 view threshold
3,936,972.22 ops/s
(+3.05%)Baseline: 3,820,598.40 ops/s
3,430,625.58 ops/s
(87.14%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (256B)📈 view plot
🚷 view threshold
3,889,650.03 ops/s
(+2.25%)Baseline: 3,803,875.96 ops/s
3,401,760.19 ops/s
(87.46%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > boolean📈 view plot
🚷 view threshold
72,744,181.21 ops/s
(+5.76%)Baseline: 68,781,914.38 ops/s
57,669,056.95 ops/s
(79.28%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > integer📈 view plot
🚷 view threshold
72,357,529.38 ops/s
(+4.82%)Baseline: 69,030,740.68 ops/s
57,336,120.73 ops/s
(79.24%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > null📈 view plot
🚷 view threshold
72,957,605.61 ops/s
(+5.08%)Baseline: 69,429,798.07 ops/s
57,887,431.71 ops/s
(79.34%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > string (100 chars)📈 view plot
🚷 view threshold
799,479.00 ops/s
(+3.15%)Baseline: 775,032.99 ops/s
700,644.35 ops/s
(87.64%)
src/tdigest.bench.ts > TDigest Benchmarks > add📈 view plot
🚷 view threshold
2.39 ops/s
(-0.26%)Baseline: 2.40 ops/s
2.34 ops/s
(97.72%)
src/tdigest.bench.ts > TDigest Benchmarks > addCentroid📈 view plot
🚷 view threshold
1.86 ops/s
(-0.78%)Baseline: 1.88 ops/s
1.82 ops/s
(97.97%)
src/tdigest.bench.ts > TDigest Benchmarks > addCentroidList📈 view plot
🚷 view threshold
1.92 ops/s
(+0.59%)Baseline: 1.91 ops/s
1.85 ops/s
(96.15%)
src/tdigest.bench.ts > TDigest Benchmarks > merge > addCentroid📈 view plot
🚷 view threshold
30,808.54 ops/s
(+0.35%)Baseline: 30,701.26 ops/s
23,974.79 ops/s
(77.82%)
src/tdigest.bench.ts > TDigest Benchmarks > merge > merge📈 view plot
🚷 view threshold
31,105.74 ops/s
(-0.62%)Baseline: 31,299.73 ops/s
26,691.40 ops/s
(85.81%)
src/tdigest.bench.ts > TDigest Benchmarks > quantile📈 view plot
🚷 view threshold
2.37 ops/s
(+0.97%)Baseline: 2.35 ops/s
2.28 ops/s
(96.04%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

🐰 Bencher Report

Branchmlaw/proc-batch-logging
Testbedself-hosted-metal

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 4 Alerts

🐰 View full continuous benchmarking report in Bencher

@tantaman tantaman added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@tantaman tantaman enabled auto-merge April 6, 2026 14:20
@tantaman tantaman added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit e19978b Apr 6, 2026
23 of 26 checks passed
@tantaman tantaman deleted the mlaw/proc-batch-logging branch April 6, 2026 14:41
arv pushed a commit that referenced this pull request Apr 17, 2026
To determine if flushing to the client is what is consuming all the time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants