Release v1.1.2#60
Conversation
Greptile SummaryThis PR releases v1.1.2 of the Python SDK, adding a Knowledge Base API (13 new endpoints covering draft management, regeneration, finalization, and lens operations) and a new artifact-retrieval endpoint for agent jobs.
Confidence Score: 3/5The generated code and models are correct, but two advertised features are completely unreachable from the public client — the KB API and the artifact-retrieval method both raise AttributeError on any call. Both the Knowledge Base API (all 13 operations) and src/roe/api/agents.py (missing retrieve_artifact), src/roe/api/_generated_registry.py and src/roe/client.py (missing KnowledgeBaseAPI registration and property) Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
Client["RoeClient"] --> AgentsAPI
Client -.->|"missing property"| KBmissing["client.knowledge_base ❌"]
AgentsAPI --> AgentJobsAPI
AgentJobsAPI --> existing["retrieve_result / cancel / download_reference / ..."]
AgentJobsAPI -.->|"missing method"| artifactMissing["retrieve_artifact ❌"]
subgraph Generated [Generated low-level code added]
KB_gen["_generated/api/knowledge_base/* (13 files)"]
artifact_gen["agents_jobs_artifacts_result_retrieve.py"]
models["New models: KnowledgeBase, Draft, DraftRef, ..."]
end
KBmissing -.-> KB_gen
artifactMissing -.-> artifact_gen
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
Client["RoeClient"] --> AgentsAPI
Client -.->|"missing property"| KBmissing["client.knowledge_base ❌"]
AgentsAPI --> AgentJobsAPI
AgentJobsAPI --> existing["retrieve_result / cancel / download_reference / ..."]
AgentJobsAPI -.->|"missing method"| artifactMissing["retrieve_artifact ❌"]
subgraph Generated [Generated low-level code added]
KB_gen["_generated/api/knowledge_base/* (13 files)"]
artifact_gen["agents_jobs_artifacts_result_retrieve.py"]
models["New models: KnowledgeBase, Draft, DraftRef, ..."]
end
KBmissing -.-> KB_gen
artifactMissing -.-> artifact_gen
Reviews (1): Last reviewed commit: "Release v1.1.2" | Re-trigger Greptile |
| coerce: uuid | ||
| - kind: body | ||
| method_name: retrieve_artifact | ||
| docstring: '' | ||
| method: GET | ||
| path: /v1/agents/jobs/{agent_job_id}/artifacts/result/ | ||
| endpoint_module: roe._generated.api.agents.agents_jobs_artifacts_result_retrieve | ||
| return_type: AgentJobArtifactResult | ||
| return_import: roe._generated.models.agent_job_artifact_result.AgentJobArtifactResult | ||
| parameters: | ||
| - name: job_id | ||
| location: path | ||
| annotation: str | ||
| coerce: uuid | ||
| - name: artifact_key | ||
| location: query |
There was a problem hiding this comment.
Path-parameter name mismatch:
job_id vs agent_job_id
The retrieve_artifact operation in wrappers.yml declares the path parameter as name: job_id, but the generated endpoint function (agents_jobs_artifacts_result_retrieve.py) uses agent_job_id as the positional parameter name (to match the {agent_job_id} URL placeholder). The SDK example also uses job_id. When the high-level wrapper is eventually implemented, it will need to translate the public job_id argument to agent_job_id for the generated function — the mismatch is a latent trap if that translation is forgotten.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This PR updates the Python SDK for release
1.1.2.Generated from:
1-0-85c912ec5a511f87eab2b1fe63f0de5ea22e7c8af4