Skip to content

feat: Implement basic definitions and essential methods for CCSNavArea#1335

Merged
roflmuffin merged 2 commits into
roflmuffin:mainfrom
ELDment:feat/navarea
Jun 16, 2026
Merged

feat: Implement basic definitions and essential methods for CCSNavArea#1335
roflmuffin merged 2 commits into
roflmuffin:mainfrom
ELDment:feat/navarea

Conversation

@ELDment

@ELDment ELDment commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Based on @roflmuffin 's feedback in #1331 (comment), and since SlynxCZ's PR does not yet include the functionality implemented here, this PR adds the missing foundation needed for that work

The goal of this PR is to help pave the way for the interesting and valuable feature proposed in #1331

@ELDment ELDment requested a review from roflmuffin as a code owner June 15, 2026 11:39
@ELDment

ELDment commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Tested successfully on Windows 11 and Ubuntu 22.04

1e47d6f546730b5002bfe678848c5406 054aa35bd44d5343b68b04aab0dcb5fd

@roflmuffin

Copy link
Copy Markdown
Owner

Thanks for the PR, looks good to me. Is there any way you could fix up/remove the white space changes in this PR?

@ELDment

ELDment commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the PR, looks good to me. Is there any way you could fix up/remove the white space changes in this PR?

alrightly, a small question: could you tell me if I need to switch all csproj files to LF?

@roflmuffin

Copy link
Copy Markdown
Owner

My apologies, I didn't realise there were still CRLF files in the repo. I've normalised the line endings and updated the .gitattributes, could you rebase on latest main?

@roflmuffin roflmuffin enabled auto-merge (squash) June 16, 2026 09:15
@roflmuffin roflmuffin merged commit c6eff28 into roflmuffin:main Jun 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants