feat: Goal-based savings tracking & milestones#754
Open
shaidshark wants to merge 2 commits intorohitdash08:mainfrom
Open
feat: Goal-based savings tracking & milestones#754shaidshark wants to merge 2 commits intorohitdash08:mainfrom
shaidshark wants to merge 2 commits intorohitdash08:mainfrom
Conversation
added 2 commits
April 3, 2026 10:41
…8#133) - Backend: SavingsGoal + SavingsContribution models - CRUD API routes with JWT auth (/savings) - Milestone tracking at 25%, 50%, 75%, 100% - Contribution system with progress auto-calculation - Auto-complete when goal target reached - Frontend: Savings page with progress bars, milestone badges - Navigation link in navbar - DB schema migration with indexes - 12 test cases covering all endpoints
- Use with_for_update() in add_contribution and delete_contribution - Prevents lost updates when concurrent contributions are made - Addresses critical race condition from code review
Author
|
Bounty submission — ready for review! All code review feedback from previous rounds has been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounty #133 — Goal-based savings tracking & milestones
What's included
Backend (Flask):
Frontend (React + TypeScript):
Tests:
Acceptance Criteria