feat: PII Export and Delete Workflow GDPR-ready (Issue #76)#768
Open
shaidshark wants to merge 4 commits intorohitdash08:mainfrom
Open
feat: PII Export and Delete Workflow GDPR-ready (Issue #76)#768shaidshark wants to merge 4 commits intorohitdash08:mainfrom
shaidshark wants to merge 4 commits intorohitdash08:mainfrom
Conversation
added 4 commits
April 3, 2026 13:03
- Fix hard delete order (dependent records before categories) - Add AuditLog and AdImpression to deletion - Wrap hard delete in transaction with rollback - Remove cross-currency sum from dashboard (separate fix) - Add missing model imports
…l tables - Fix delete order: dependent records before categories (FK constraints) - Add AdImpression and AuditLog to cleanup - Wrap in try/except with rollback for atomicity - Add synchronize_session=False for batch deletes
…hreadPoolExecutor - Add AdImpression to imports in gdpr.py (was causing NameError) - Replace threading.Thread with bounded ThreadPoolExecutor(max_workers=2) to prevent DoS via unbounded thread creation - Addresses review feedback from rohitdash08#768
Author
|
Bounty submission — ready for review! All code review feedback from previous rounds has been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Issue #76 — GDPR-ready PII Export and Delete Workflow.
Features:
GDPR Compliance: