feat: Goal-based savings tracking & milestones (#133)#773
Open
wocaoac-cpu wants to merge 1 commit intorohitdash08:mainfrom
Open
feat: Goal-based savings tracking & milestones (#133)#773wocaoac-cpu wants to merge 1 commit intorohitdash08:mainfrom
wocaoac-cpu wants to merge 1 commit intorohitdash08:mainfrom
Conversation
Add complete savings goals feature with: - SavingsGoal and SavingsGoalMilestone models with status tracking - Service layer: CRUD, contributions, withdrawals, auto milestone detection - REST API: GET/POST /savings-goals, PATCH/DELETE /savings-goals/:id, POST contribute/withdraw endpoints - Default milestones at 25%, 50%, 75%, 100% with custom override support - Auto-completion when goal reaches 100% - Filter goals by status (ACTIVE/COMPLETED/CANCELLED) - 15 comprehensive tests covering all endpoints and edge cases - OpenAPI 3.0 documentation for all new endpoints and schemas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #133
SavingsGoalandSavingsGoalMilestonewith status tracking (ACTIVE/COMPLETED/CANCELLED), progress calculation, and automatic milestone detectionservices/savings_goals.py): Full CRUD, contribute/withdraw operations, auto-milestone checking, auto-completion at 100%routes/savings.py): 7 endpoints under/savings-goals— list (with status filter), get, create, update, delete (cancel), contribute, withdrawEndpoints
/savings-goals?status=filter)/savings-goals/savings-goals/:id/savings-goals/:id/savings-goals/:id/savings-goals/:id/contribute/savings-goals/:id/withdrawTest plan
Note: Existing test suite requires a running Redis instance for the auth fixture (
_store_refresh_session). This is a pre-existing infrastructure requirement, not introduced by this PR.