fix(cli): add clear warning when import-jsonl brings zero files#927
fix(cli): add clear warning when import-jsonl brings zero files#927sham-jadhav03 wants to merge 1 commit into
Conversation
|
@sham-jadhav03 is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CLI's ChangesImport Result Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
This PR addresses a silent data-loss scenario where running
agentmemory import-jsonlcompletes successfully with a deceptive success status even when0valid historical session logs are imported (often due to Claude Code's nativecleanupPeriodDays: 30auto-purge setting).Changes
runImportJsonl().json.importedevaluates to0or is undefined, the CLI now prints a clean warning (p.log.warn) alerting the user about the missing files and the Claude Code cleanup policy.agentmemory connect claude-code --with-hooks.Verification Done
npm run build.npm test) locally, ensuring all 1423+ unit and integration tests continue to pass seamlessly without any regression.Summary by CodeRabbit