-
-
Notifications
You must be signed in to change notification settings - Fork 126
feat(migrate): add monorepo support for tsup migration script #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
8dea631 to
885cf20
Compare
885cf20 to
ebaf82c
Compare
710ba4e to
ccd17b1
Compare
ebaf82c to
885cf20
Compare
sxzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to introduce a new dependency, so we can use tsdown-migrate [...dirs], e.g., tsdown-migrate packages/*.
885cf20 to
159ed8c
Compare
159ed8c to
3ade8f4
Compare
sxzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is tinyglobby really necessary? I think shells like bash will also resolve glob patterns.
In my local, if I remove tinyglobby and rely directly on shell expansion like this, it would break support for PowerShell on Windows. const baseCwd = process.cwd()
const cwds =
dirs && dirs.length > 0
? dirs.map((d) => path.resolve(baseCwd, d))
: [baseCwd] |
|
Ah... PowerShell... |
Description
Add monorepo support for the
tsupmigration script. If executed in the monorepo root, the script will run sequentially in the current directory and in each package directory. In all other cases, it will still run only in the specified directory.Linked Issues
Resolves #452
Additional context
The testing fixtures of this PR might not be in the best shape. Need comment.