Open
Conversation
oren-z0
force-pushed
the
cdb
branch
2 times, most recently
from
073486f to
7ae2b47
Compare
Also update rust version to 1.88.0 - Required by cdb64 0.2.0, which uses let chain expressions (stabilized in Rust 1.88.0).
oren-z0
force-pushed
the
cdb
branch
2 times, most recently
from
3791257 to
5bce34d
Compare
Owner
|
Please consider retargeting this PR to https://github.com/romanz/bindex - |
oren-z0
force-pushed
the
cdb
branch
2 times, most recently
from
ab777b4 to
8543def
Compare
There are still duplications between the RocksDB and the cdb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksDB is a great key-value storage for mutable data, but most data in Bitcoin is immutable.
CDB64 is a very fast database for immutable data - using reference tables like this:
Originally CDB uses 32bits pointers, but cdb64 uses 64bits, source: https://www.unixuser.org/~euske/doc/cdbinternals/index.html.
Building the reference tables is a slow process, so the CDB can't replace RocksDB for fresh data. For example, we can store all the data up to block 900,000 in CDBs, and on query, search for it both in the CDB and the much-smaller RocksDB.
I haven't run benchmarks yet.