Refactor: Logging, Module Restructure, and Codebase Streamlining#4
Merged
Refactor: Logging, Module Restructure, and Codebase Streamlining#4
Conversation
…gurations Added logging setup functionality to initialize logging for the MatGraphDB application. This includes a custom user-friendly formatter for better visibility of warnings and errors. Updated configuration loading to create a user-specific config file if it does not exist, enhancing user experience and maintaining consistent logging practices. Refactored the config module to utilize the new logging setup and removed deprecated logging configurations from the YAML file.
Deleted the entire calculations module, including all related files such as calc_manager.py, job_scheduler_generator.py, parsers.py, and others. This change is part of a broader refactor to streamline the codebase and remove unused or redundant components. No functionality is affected as the calculations module is no longer needed in the current architecture.
Deleted the entire graph_kit module, including all related files such as data.py, graph_manager.py, metadata.py, nodes.py, relationships.py, and others. This change is part of a broader refactor to streamline the codebase and remove unused or redundant components. No functionality is affected as the graph_kit module is no longer needed in the current architecture.
Refactored the import paths for edge and node generators to align with the new module structure. This change includes moving functions from `matgraphdb.core.nodes` and `matgraphdb.core.edges` to `matgraphdb.generators.nodes` and `matgraphdb.generators.edges`. Additionally, created a new `material_store.py` file to encapsulate the `MaterialStore` class, improving organization and maintainability of the codebase. No functionality is affected as the core logic remains intact, but the restructuring enhances clarity and prepares for future development.
…g utility Removed the `set_verbosity` function from `general_utils.py` and updated the import in `material_store.py` to use `set_verbose_level` from `log_utils.py`. This change aligns the logging configuration with the new logging structure established in previous commits, improving consistency and maintainability of the logging setup.
Replaced the existing material_0.parquet file with a new version. Due to the repository directory structure change, the metadata has to change
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject: Refactor: Logging, Module Restructure, and Codebase Streamlining
This PR introduces a series of refactoring and cleanup changes aimed at improving the codebase's maintainability, organization, and user experience.
Key changes include:
Logging Overhaul (c701618):
Module Removal (0ba9d8e, bb15abb):
calculationsmodule and all its associated files (e.g.,calc_manager.py,job_scheduler_generator.py,parsers.py).graph_kitmodule and all its associated files (e.g.,data.py,graph_manager.py,metadata.py,nodes.py,relationships.py).Import Path and Structure Refactoring:
matgraphdb.core.nodesandmatgraphdb.core.edgestomatgraphdb.generators.nodesandmatgraphdb.generators.edgesrespectively.material_store.pyfile to encapsulate theMaterialStoreclass, improving code organization and maintainability.These updates collectively contribute to a cleaner, more efficient, and developer-friendly codebase.