[cmake][win] Fix issue #9354 #18315
Closed
[cmake][win] Fix issue #9354 #18315
+28
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the $<CONFIG> (Debug, Release, ...) subdirs for gtest
Test Results 22 files 22 suites 3d 21h 4m 57s ⏱️ Results for commit f5d8af7. ♻️ This comment has been updated with latest results. |
Member
Author
|
To be tested more carefully |
Use `CMAKE_CURRENT_BINARY_DIR` instead of `CMAKE_CURRENT_BINARY_DIR/$<CONFIG>`
dpiparo
approved these changes
Jan 10, 2026
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Good to go provided that the merge commits are removed.
bellenot
added a commit
to bellenot/root
that referenced
this pull request
Jan 13, 2026
Don't use the Debug, Release, ... subdirs for gtest supersedes root-project#18315 and fixes root-project#9354
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the Debug, Release, ... subdirs for gtest
This PR fixes #9354