[CI] Disable PyMVA so we can support the newest TensorFlow versions #19124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 10h 16m 24s ⏱️ Results for commit e39182a. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
The changes suggested by this PR should only be merged after the tutorial selection system is fixed by this other PR: Like this, we avoid bad surprises when we eventually enable |
Member
|
@lmoneta @sanjibansg could you make sure the tests are correctly running on all platforms once this PR is merged and then re-enable them? |
guitargeek
force-pushed
the
disable_pymva
branch
from
68cae38 to
baa149f
Compare
Contributor
Author
|
Now that the tutorial tests were are restored by merging #19123, it became apparent that the |
guitargeek
force-pushed
the
disable_pymva
branch
from
baa149f to
5673cf7
Compare
guitargeek
force-pushed
the
disable_pymva
branch
from
5673cf7 to
cff82b2
Compare
Right now we don't support the newest TensorFlow releases after the 2.15 series, initially released in November 2023 [1]. Support for TensorFlow>=2.16 is worked on [2], but it's difficult to make progress if we don't have TensorFlow>=2.16 in our CI images. And we veto it from our CI image via the `requirements.txt` mechanism. To continue, we need to temporarily disable PyMVA in the CI, such that we can include the newest TensorFlow version in our images, and then re-enable it in the PR that fixes support for the newest TensorFlow. This is what is done in this commit. Supporting the newest TensorFlow became a bit more important now that we also have another feature besides PyMVA that uses TensorFlow: the RBatchGenerator. It would not good to hold off testing the actively-developed RBatchGenerator on newer TensorFlow versions, just because PyMVA prevents us from installing these on our CI. [1] https://github.com/tensorflow/tensorflow/releases [2] root-project#15790
guitargeek
force-pushed
the
disable_pymva
branch
from
cff82b2 to
e39182a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we don't support the newest TensorFlow releases after the 2.15 series, initially released in November 2023 [1].
Support for TensorFlow>=2.16 is worked on [2], but it's difficult to make progress if we don't have TensorFlow>=2.16 in our CI images. And we veto it from our CI image via the
requirements.txtmechanism.To continue, we need to temporarily disable PyMVA in the CI, such that we can include the newest TensorFlow version in our images, and then re-enable it in the PR that fixes support for the newest TensorFlow. This is what is done in this commit.
Supporting the newest TensorFlow became a bit more important now that we also have another feature besides PyMVA that uses TensorFlow: the RBatchGenerator. It would not good to hold off testing the actively-developed RBatchGenerator on newer TensorFlow versions, just because PyMVA prevents us from installing these on our CI.
[1] https://github.com/tensorflow/tensorflow/releases
[2] #15790