[hist] Disable thread-safe TH3D on 32-bit platforms. #20874
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32 bits, the alignment of double is less strict than for atomic_ref<double>, so TH3D::FillThreadSafe cannot be used. Fix root-project#20834.
Member
|
Shouldn't we rather fix the alignment of the variables in question? |
Test Results 23 files 23 suites 4d 1h 17m 32s ⏱️ Results for commit a78974f. |
Member
Author
It's a valid alternative, but I guess the work to be invested outweighs the benefits. This would only be used on 32-bit platforms with multithreaded filling from RDF with C++20. And more importantly, with RHist integrated in RDF, I would actually remove this function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32 bits, the alignment of double is less strict than for atomic_ref, so TH3D::FillThreadSafe cannot be used.
Tested the
#if definedin a 32 bit container, and it indeed disables the Fill function. I couldn't reproduce the alignment failure, though, since it ran on a 64 bit machine that kept the alignment at 64.Fix #20834.