Skip to content

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Jan 14, 2026

hadd is trying to use std::filesystem::equivalent indiscriminately for any source and target files, but the function only makes sense for local files.

This PR adds a function that checks if the files are remote and, if so, if simply compares their URL.

NOTE: this PR should be backported to 6.38.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #20872

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hadd crashes when already existing output file is used with remote file input paths

2 participants