[hadd] Fix file equivalence test in case of remote files #20878
+32
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haddis trying to usestd::filesystem::equivalentindiscriminately for any source and target files, but the function only makes sense for local files.This PR adds a function that checks if the files are remote and, if so, if simply compares their URL.
NOTE: this PR should be backported to 6.38.
Checklist:
This PR fixes #20872