[civetweb] download from GIT instead of bundle, bump from 1.16+ to latest master, and define proper CMake target

[ferdymercury]

Cleaned-up version of #21947

[dpiparo]

thanks for this sizable effort!

[dpiparo]

If everything works, and we go with this solution, we should perhaps move the source tarball to the LCG Packages, as all the others.

[ferdymercury]

If everything works, and we go with this solution, we should perhaps move the source tarball to the LCG Packages, as all the others.

Sounds good to me. In that case, it should be downloaded from commit civetweb/civetweb@588860e (no tagged version) and I guess upload it to LCG with name:

civetweb-1.16-588860.tar.gz

[github-actions]

Test Results

    23 files      23 suites   3d 19h 15m 40s ⏱️
 3 853 tests  3 851 ✅ 0 💤 2 ❌
78 505 runs  78 502 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit e74a118.

♻️ This comment has been updated with latest results.

[ferdymercury]

@linev It seems opensuse16 machine is missing one of the packages ? I tried here: root-project/root-ci-images#141

  CMake Error at /usr/lib64/cmake/civetweb/civetweb-targets.cmake:106 (message):
    The imported target "civetweb::server" references the file
       "/usr/bin/civetweb"
    but this file does not exist.  Possible reasons include:
    * The file was deleted, renamed, or moved to another location.
    * An install or uninstall procedure did not complete successfully.
    * The installation package was faulty and contained
       "/usr/lib64/cmake/civetweb/civetweb-targets.cmake"
    but not all the files it references.
  Call Stack (most recent call first):
    /usr/lib64/cmake/civetweb/civetweb-config.cmake:57 (include)
    cmake/modules/SearchInstalledSoftware.cmake:539 (find_package)
    CMakeLists.txt:136 (include)

[linev]

For me PR looks ready now!

Lets wait until new opensuse image produced and one can see its proper usage

[ferdymercury]

It seems it's still failing but in another place: can you reproduce locally on opensuse16? Or is it a clean-build issue?

Maybe it's complaining here?
get_target_property(CIVETWEB_IMPORTED_LOCATION civetweb::civetweb IMPORTED_LOCATION_NONE)

Could it be that the version of civetweb 1.15 (instead of 1.16) does not have this target property ? Can you check if it's done differently in 1.15 civetwebconfig.cmake ?

[linev]

get_target_property(CIVETWEB_IMPORTED_LOCATION civetweb::civetweb IMPORTED_LOCATION_NONE)

I got error:

-- Found civetweb version 1.16.0
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
CIVETWEB_IMPORTED_LOCATION
    linked by target "cmTC_385e9" in directory /home/linev/build/ddd/CMakeFiles/CMakeScratch/TryCompile-1kfjh1

CMake Error at cmake/modules/SearchInstalledSoftware.cmake:550 (try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  CMakeLists.txt:136 (include)

As you can see - it is civetweb 1.16.

And here is content of civetweb-config.cmake:

####### Expanded from @PACKAGE_INIT@ by configure_package_config_file() #######
####### Any changes to this file will be overwritten by the next CMake run ####
####### The input file was civetweb-config.cmake.in                            ########

get_filename_component(PACKAGE_PREFIX_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../" ABSOLUTE)

# Use original install prefix when loaded through a "/usr move"
# cross-prefix symbolic link such as /lib -> /usr/lib.
get_filename_component(_realCurr "${CMAKE_CURRENT_LIST_DIR}" REALPATH)
get_filename_component(_realOrig "/usr/lib64/cmake/civetweb" REALPATH)
if(_realCurr STREQUAL _realOrig)
  set(PACKAGE_PREFIX_DIR "/usr")
endif()
unset(_realOrig)
unset(_realCurr)

macro(set_and_check _var _file)
  set(${_var} "${_file}")
  if(NOT EXISTS "${_file}")
    message(FATAL_ERROR "File or directory ${_file} referenced by variable ${_var} does not exist !")
  endif()
endmacro()

####################################################################################
include(CMakeFindDependencyMacro)

set_and_check(civetweb_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include")
set_and_check(civetweb_INCLUDE_DIRS "${PACKAGE_PREFIX_DIR}/include")
set_and_check(civetweb_LIBRARY_DIRS "${PACKAGE_PREFIX_DIR}/lib64")
set(civetweb_LIBRARIES civetweb)

if(ON)
  set(civetweb-cpp_LIBRARIES civetweb-cpp)
endif()

find_dependency(Threads)

set(CIVETWEB_SAVED_MODULE_PATH ${CMAKE_MODULE_PATH})
list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})

if(FALSE)
  find_dependency(LibDl)
endif()

if(TRUE)
  find_dependency(LibRt)
endif()

if(FALSE)
  find_dependency(WinSock)
endif()

set(CMAKE_MODULE_PATH ${CIVETWEB_SAVED_MODULE_PATH})
unset(CIVETWEB_SAVED_MODULE_PATH)

include("${CMAKE_CURRENT_LIST_DIR}/civetweb-targets.cmake")

[ferdymercury]

Thanks!

Could you check if adding this below get_target_property would help?

if(NOT CIVETWEB_IMPORTED_LOCATION OR CIVETWEB_IMPORTED_LOCATION MATCHES "NOTFOUND")
  get_target_property(CIVETWEB_IMPORTED_LOCATION civetweb::civetweb IMPORTED_LOCATION_RELEASE)
  if(NOT CIVETWEB_IMPORTED_LOCATION OR CIVETWEB_IMPORTED_LOCATION MATCHES "NOTFOUND")
    get_target_property(CIVETWEB_IMPORTED_LOCATION civetweb::civetweb IMPORTED_LOCATION_RELWITHDEBINFO)
  endif()
endif()

It could also be it's called NOCONFIG or DEBUG or ...

Maybe there is more info in this file:
("${CMAKE_CURRENT_LIST_DIR}/civetweb-targets.cmake")

[linev]

Yes, with your addition cmake works.
It is IMPORTED_LOCATION_RELWITHDEBINFO

[ferdymercury]

Test failures seem unrelated.

[linev]

It is sensitive PR, therefore I close and open PR to start from clean build

[ferdymercury]

Looking green :)

[guitargeek]

Thank you very much!

• ROOT downloads civetweb from the internet now instead of containing its source, which is alighted with the overall direction we go into for dependencies
• Build system behavior changes like defaulting to builtin_civetweb=OFF were requested by Sergey, who already approved the PR
• builtin_civetweb=OFF is exercised in the CI on opensuse16

[hahnjo]

On my system, I get looads of output during building and installing civetweb - can this be quieted as for other builtins?