[cling] remove outdated external LLVM header workaround - #23069
Merged
Conversation
Test Results 23 files 23 suites 3d 17h 47m 54s ⏱️ For more details on these failures, see this check. Results for commit 5746781. ♻️ This comment has been updated with latest results. |
ferdymercury
changed the title
ferdymercury
marked this pull request as draft
August 12, 2026 15:05
ferdymercury
changed the title
ferdymercury
marked this pull request as ready for review
August 12, 2026 15:22
2 tasks
hahnjo
approved these changes
Aug 18, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
LGTM, but can you please avoid abbreviations in the commit header? [cling] Remove outdated LLVM header workaround
with external LLVM22, no longer needed since patched headers have reached stable v22
ferdymercury
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with LLVM22, maybe this hunk is no longer needed since patched headers have reached stable v22? At least that's what I understand from this comment: #19265 (comment)
Tested locally on Ubu26 and it seemed ok (getting an unrelated error though in a later place), with CI it will not show yet effects: To be confirmed once #22584 is inside