Change markers drawing in TSVG - #23094
Open
linev wants to merge 3 commits into
Open
Conversation
couet
approved these changes
Aug 18, 2026
linev
force-pushed
the
svg_marker
branch
2 times, most recently
from
August 18, 2026 14:05
4d52160 to
8e7df11
Compare
linev
marked this pull request as ready for review
August 18, 2026 14:07
Use TAttMarker::GetMarkerShape() to retrieve marker shape and draw it with SVG `<path>` expression. Use integer coordinates for relative path movement Add space between markers in path d attribute to have proper line breaks
Now instead of <g> always combined <path> is used. Representation is more precise and compact
Test Results 15 files 15 suites 2d 4h 54m 4s ⏱️ For more details on these failures, see this check. Results for commit 50d709f. ♻️ This comment has been updated with latest results. |
Marker representaion of the circle is changed. Now it is shown as svg:path with 'a' element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
TAttMarker::GetMarkerShape().Update svg_ref files because markers implementation was changed