incorporate data from Grabe et al (2016)#23
Open
schlegelp wants to merge 6 commits into
Open
Conversation
This file is not part of the original DoOR database.
- change data/Grabe.2016 to just Grabe.2016 - also adds new odours that got lost previously somehow
Some files had to be exported manually again.
Author
|
I'm not sure what the problem is but if you give me a pointer as to what is, I will try fixing that. |
|
The requirement for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerating the database via
export_door_dataandwrite.csv(for individual files) changed delimiter from colon to comma. Not sure if that's acceptable but it results in nicer formatting of the tables on Github. Downside is that it makes comparing changes to the actual data hard to spot. I'm happy to provide the.csvfile with Grabe et al raw data used forimport_new_dataif that's helpful. All optional parameters were left at their default values during import/export.Still missing: entry for Grabe et al in
door_dataset_info.csv.