Skip to content

incorporate data from Grabe et al (2016)#23

Open
schlegelp wants to merge 6 commits into
ropensci:masterfrom
schlegelp:master
Open

incorporate data from Grabe et al (2016)#23
schlegelp wants to merge 6 commits into
ropensci:masterfrom
schlegelp:master

Conversation

@schlegelp

Copy link
Copy Markdown

Regenerating the database via export_door_data and write.csv (for individual files) changed delimiter from colon to comma. Not sure if that's acceptable but it results in nicer formatting of the tables on Github. Downside is that it makes comparing changes to the actual data hard to spot. I'm happy to provide the .csv file with Grabe et al raw data used for import_new_data if that's helpful. All optional parameters were left at their default values during import/export.

Still missing: entry for Grabe et al in door_dataset_info.csv.

schlegelp and others added 6 commits May 31, 2018 14:26
This file is not part of the original DoOR database.
- change data/Grabe.2016 to just Grabe.2016
- also adds new odours that got lost previously somehow
Some files had to be exported manually again.
@schlegelp

Copy link
Copy Markdown
Author

I'm not sure what the problem is but if you give me a pointer as to what

1. Error: all odors are present in data objects (@test_consistency.R#10) 
2. Error: data is numeric (@test_consistency.R#15) 
3. Failure: odors are not duplicated (@test_consistency.R#20)

is, I will try fixing that.

@jefferis

Copy link
Copy Markdown

The requirement for ; separated CSVs is baked into utils::data

files ending ‘.csv’ or ‘.CSV’ are read using read.table(..., header = TRUE, sep = ";", as.is=FALSE), and also result in a data frame.
which is what is used to load the raw csvs into an R session in

load_door_data <- function(nointeraction = FALSE) {
if (nointeraction == FALSE) {
answer <- ""
while (answer != "n" & answer != "y") {
answer <-
readline(
"This will load all DoOR data into the current environment, possibly
overwriting existing data. Continue? (y/n)? "
)
if (answer == "y")
break()
if (answer == "n")
stop("aborted loading data")
}
}
all.data <- utils::data(package = "DoOR.data")
utils::data(list = all.data$results[, 3])
}

@Dahaniel Dahaniel self-assigned this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants