preserve PKG_CONFIG_PATH instead of overwriting it#11
Merged
berndpfrommer merged 1 commit intoMar 10, 2026
Merged
Conversation
Signed-off-by: Alistair English <alistair.e@greenforgelabs.com.au>
333cb93
into
ros-misc-utilities:master
7 of 8 checks passed
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've come across this repo as a depenency for foxglove_compressed_video_transport - thanks for your work on both!
The Problem:
set(ENV{PKG_CONFIG_PATH} ${FFMPEG_PKGCONFIG})unconditionally overwritesPKG_CONFIG_PATH. SinceFFMPEG_PKGCONFIGdefaults to an empty string, this blanks out the entire variable during cmake configure.This works on Ubuntu by accident because ffmpeg's
.pcfiles live in pkg-config's default search path. But it breaks when using Nix or cross-compilation setups.Proposed fix:
FFMPEG_PKGCONFIGtoPKG_CONFIG_PATHinstead of replacing it, and only when it's non-emptyI also removed a duplicated pkg-config discovery block in
CMakeLists.txt