Merged
Conversation
…uild this crate as a ros package
maspe36
commented
Apr 11, 2026
|
@maspe36 thanks! I'll rebase ros2-rust/ros2_rust#556 once I merge this and then review it. |
Collaborator
Author
|
Verified windows builds work with this change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the windows build failure for rclrs in ros2-rust/ros2_rust#556
We were not handling paths for windows correctly. Now we get the absolute path to the generated
.rsfiles and include those. This should handle all platform differences (similar tocanonicalize()), exceptstd::path::absolutedoes not resolve symlinks.https://doc.rust-lang.org/stable/std/path/fn.absolute.html
I am testing this PR with this draft PR in rclrs. Ideally this repo should have CI as well, but this requires more effort and shouldn't be rushed solely for this change.
ros2-rust/ros2_rust#623