Add ConstRefCallback in use_take_shared_method

[mini-1235]

Related to our discussion in https://discourse.openrobotics.org/t/performance-characteristics-subscription-callback-signatures-rmw-implementation-intra-process-communication-ipc/51454/7?u=mini-1235

it seems like ConstRefCallback is missing in use_take_shared_method

[fujitatomoya]

lgtm with green CI.

while the naming is a bit misleading, "take shared" is appropriate for any callback that doesn't require exclusive ownership, i think. and that includes both shared-pointer callbacks and const-reference callbacks.

[fujitatomoya]

Pulls: #3066
Gist: https://gist.githubusercontent.com/fujitatomoya/967ec7dafb600506a0323b361c3f62bd/raw/35435ee094cc258fe3d1f204984da08f494371ab/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18212

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mini-1235]

Let me try to rebase and see if it fixes the build failure

[mini-1235]

15:19:18 99: 
15:19:18 99: [  FAILED  ] TestBusyWaiting/EventsExecutor.test_spin, where TypeParam = rclcpp::experimental::executors::EventsExecutor (10011 ms)
15:19:18 99: [----------] 3 tests from TestBusyWaiting/EventsExecutor (10029 ms total)
15:19:18 99: 
15:19:18 99: [----------] Global test environment tear-down
15:19:18 99: [==========] 9 tests from 3 test suites ran. (10123 ms total)
15:19:18 99: [  PASSED  ] 8 tests.
15:19:18 99: [  FAILED  ] 1 test, listed below:
15:19:18 99: [  FAILED  ] TestBusyWaiting/EventsExecutor.test_spin, where TypeParam = rclcpp::experimental::executors::EventsExecutor
15:19:18 99: 
15:19:18 99:  1 FAILED TEST
15:19:18 99: -- run_test.py: return code 1
15:19:18 99: -- run_test.py: inject classname prefix into gtest result file '/tmp/ws/test_results/rclcpp/test_executors_busy_waiting.gtest.xml'
15:19:18 99: -- run_test.py: verify result file '/tmp/ws/test_results/rclcpp/test_executors_busy_waiting.gtest.xml'
15:19:18  99/122 Test  #99: test_executors_busy_waiting ..............................***Failed   10.35 sec

I don't think this is related to this PR, right?

[fujitatomoya]

Yup, let me re-run the CI.

[fujitatomoya]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[fujitatomoya]

• Linux

[mini-1235]

@fujitatomoya is this good to merge now? 😄

[ahcorde]

Pulls: #3066
Gist: https://gist.githubusercontent.com/ahcorde/17420dca3000d654e08f2f3e965ff472/raw/35435ee094cc258fe3d1f204984da08f494371ab/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18661

• Linux
• Linux-aarch64
• Linux-rhel
• Windows