Skip to content

Added tracepoint for rclcpp_take event when message loaning is used#3103

Open
nightduck wants to merge 1 commit intoros2:rollingfrom
nightduck:tracing_rclcpp_take_zero_copy
Open

Added tracepoint for rclcpp_take event when message loaning is used#3103
nightduck wants to merge 1 commit intoros2:rollingfrom
nightduck:tracing_rclcpp_take_zero_copy

Conversation

@nightduck
Copy link

Description

It's difficult to fully trace a system when using zero-copy because the rclcpp_take tracepoint is not invoked. This corrects for that.

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
@nightduck nightduck marked this pull request as draft March 18, 2026 09:24
@jmachowinski
Copy link
Collaborator

I would rather add the tracepoint to rcl_take_loaned_message, as the tracepoint for rcl_take is also in rcl.
This would also fix rclpy tracing as well.

@nightduck
Copy link
Author

nightduck commented Mar 18, 2026

When a message take is performed, there's 3 trace points called: rclcpp_take, rcl_take, and rmw_take. I'm already working on the last 2 with PRs in other packages. But rclcpp_take doesn't get triggered when subscription->can_loan_messages() is true

@nightduck nightduck marked this pull request as ready for review March 18, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants