Skip to content

test: remove unnecessary sleep in waitable test #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anusha-Sharma-2 wants to merge 2 commits into
base: rolling
Choose a base branch
from
+0 −5
Open

test: remove unnecessary sleep in waitable test #3111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6bc2f
test: remove unnecessary sleep in waitable test
Anusha-Sharma-2 Mar 24, 2026
2715400
test: simplify execute logic by removing unnecessary else branch
Anusha-Sharma-2 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions rclcpp/test/rclcpp/executors/test_waitable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ TestWaitable::execute(const std::shared_ptr<void> &)
count_++;
if (nullptr != on_execute_callback_) {
on_execute_callback_();
} else {
// TODO(wjwwood): I don't know why this was here, but probably it should
// not be there, or test cases where that is important should use the
// on_execute_callback?
std::this_thread::sleep_for(3ms);
Comment on lines -82 to -85
Copy link
Collaborator

@fujitatomoya fujitatomoya Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any rational reason that we can remove this sleep instead of being said by this comment? the comment here looks pretty old, and code base could be really different as it grows. i do not think relying only on the comment would be good enough to modify and change the behavior?

}
}

Expand Down