Skip to content

Clarify distinction between FAILURE and ERROR in CallbackReturn #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saigirish23 wants to merge 1 commit into
base: rolling
Choose a base branch
from
+7 −5
Open

Clarify distinction between FAILURE and ERROR in CallbackReturn #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclcpp/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>rclcpp</name>
<version>31.0.0</version>
<version>31.0.1</version>
<description>The ROS client library in C++.</description>

<maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer>
Expand Down
2 changes: 1 addition & 1 deletion rclcpp_action/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>rclcpp_action</name>
<version>31.0.0</version>
<version>31.0.1</version>
<description>Adds action APIs for C++.</description>

<maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer>
Expand Down
2 changes: 1 addition & 1 deletion rclcpp_components/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>rclcpp_components</name>
<version>31.0.0</version>
<version>31.0.1</version>
<description>Package containing tools for dynamically loadable components</description>

<maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer>
Expand Down
4 changes: 3 additions & 1 deletion rclcpp_lifecycle/include/rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,15 @@ class LifecycleNodeInterface
LifecycleNodeInterface() {}

public:
/// Return values for lifecycle transition callbacks.
///
/// See lifecycle_msgs/msg/Transition.msg for detailed semantics.
enum class CallbackReturn : uint8_t
{
SUCCESS = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_SUCCESS,
FAILURE = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_FAILURE,
ERROR = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_ERROR
};

/// Callback function for configure transition
/*
* \return SUCCESS by default
Expand Down
2 changes: 1 addition & 1 deletion rclcpp_lifecycle/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>rclcpp_lifecycle</name>
<version>31.0.0</version>
<version>31.0.1</version>
<description>Package containing a prototype for lifecycle implementation</description>

<maintainer email="ivanpauno@ekumenlabs.com">Ivan Paunovic</maintainer>
Expand Down