Refactor Check Fields into helper function #246
+242
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Contributor
Author
|
@christophebedard would you be able to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the work around making sequences cast to list it required several changes to the spaghetti which was the template around it. This PR only moves the spaghetti out into python where making these changes is easier to test going forward and easier to enforce coding standards. A big of the reason this was done is the upcoming draft of the PR I had it basically required running this block a second time in some cases and the way it was templated it just was not possible without just copying the whole block and hoping.
I tested this make no difference by running
diff -ron the messages generated by base rolling and this branch to ensure there were no difference.Is this user-facing behavior change?
No It should only be an internal design detail.
Did you use Generative AI?
Additional Information