Skip to content

jks2pem improvements #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ehrhardt wants to merge 5 commits into
base: master
Choose a base branch
from
Open

jks2pem improvements #4

ehrhardt wants to merge 5 commits into from

Conversation

@ehrhardt
Copy link

@ehrhardt ehrhardt commented Jan 1, 2021

Thank you for the script.
Some minor changes that I hope that you like:

  • dos2unix to remove the carriage returns;
  • POSIX shell works fine since we have no bashisms;
  • quotes to enclose the file names and support spaces on paths;
  • fix a missing backslash typo;
  • rm with a prompt to give the option to delete the PKCS #12 intermediate file.

@ehrhardt ehrhardt mentioned this pull request Jan 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ehrhardt