Open
Conversation
|
@rowanhill Let me know what you think about it :) |
Owner
|
Interesting. I'm a little reluctant to adopt this, though, as it's a departure from the WireMock Java API. Do you think there's any reason this pattern is needed in the PHP bindings but not in Java? Also, if we did include this, I'd like to see some tests covering this use case. |
|
Keep in mind that for example Surely, will provide a test with use case here, wasn't just sure what are yout thoughts about it. I had an use case where I would like to just use that request pattern already built later. Will provide tests later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a change to allow RequestPattern to be used instead of RequestPatternBuilder. Use case for it is quite obvious for example:
We first use
Wiremock::sutbForwhich returnsStubMappinginstance, withRequestPatternbeing there. Then we can simply access that request pattern and pass it toverifymethod directly.