Draft: Add missing property types by pscheit · Pull Request #24 · rowanhill/wiremock-php

pscheit · 2025-06-24T18:41:56Z

have to think about how to continue and if this makes sense and how

maybe you can look at my comments questions.

Of course I will split this PR in several smaller PRs, one by one.

…use we have a lot errors

…se of mixed types

…e test + and src/WireMock/SerDe and src/WireMock/SerdeGen) Now unit tests are broken, because I added a lot of "mixed" property types, that are not supported by the Deserialization library.

pscheit · 2025-06-24T18:44:10Z

config/phpstan/Hamcrest/AnyOf.stub

my next Project is then to type Hamcrest ;)

pscheit · 2025-06-24T18:45:39Z

src/WireMock/SerdeGen/SerdeTypeParser.php

 use phpDocumentor\Reflection\Types\Object_;
 use phpDocumentor\Reflection\Types\String_;
-use phpDocumentor\Reflection\Types\True_;
+use phpDocumentor\Reflection\PseudoTypes\True_;


that way the real class is used (not the alias)

pscheit · 2025-06-24T18:46:29Z

src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php

+            try {
+                $propType = $this->serdeTypeParser->resolveTypeToSerdeType($varTag->getType());
+            } catch (SerializationException $e) {
+                throw new SerializationException('Cannot resolve type from '.$parentClass.'::$'.$refProp->getName().' with @var of '.$varTag->getType(), 0, $e);
+            }


added this to debug the failing tests. This creates a chain of exceptions that allow you to see whats actually failing:

1) WireMock\SerdeGen\WireMockSerdeGenTest::testGeneratingLookup WireMock\Serde\SerializationException: Cannot resolve type from WireMock\Client\GetServeEventsResult::$requests with @var of \WireMock\Client\ServeEvent[] /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:140 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:53 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeLookupFactory.php:25 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/WireMockSerdeGen.php:57 /home/psc/projects/wiremock-php/test/WireMock/SerdeGen/WireMockSerdeGenTest.php:18 /home/psc/projects/wiremock-php/test/WireMock/HamcrestTestCase.php:17 phpvfscomposer:///home/psc/projects/wiremock-php/vendor/phpunit/phpunit/phpunit:97 Caused by WireMock\Serde\SerializationException: Cannot resolve type from WireMock\Client\ServeEvent::$response with @var of \WireMock\Client\LoggedResponse /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:140 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:141 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:122 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:73 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:53 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeLookupFactory.php:25 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/WireMockSerdeGen.php:57 /home/psc/projects/wiremock-php/test/WireMock/SerdeGen/WireMockSerdeGenTest.php:18 /home/psc/projects/wiremock-php/test/WireMock/HamcrestTestCase.php:17 phpvfscomposer:///home/psc/projects/wiremock-php/vendor/phpunit/phpunit/phpunit:97 Caused by WireMock\Serde\SerializationException: Cannot resolve type from WireMock\Client\LoggedResponse::$headers with @var of array<int|string,mixed> /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:140 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:141 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:122 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:73 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:53 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeLookupFactory.php:25 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/WireMockSerdeGen.php:57 /home/psc/projects/wiremock-php/test/WireMock/SerdeGen/WireMockSerdeGenTest.php:18 /home/psc/projects/wiremock-php/test/WireMock/HamcrestTestCase.php:17 phpvfscomposer:///home/psc/projects/wiremock-php/vendor/phpunit/phpunit/phpunit:97 Caused by WireMock\Serde\SerializationException: Unsupported type phpDocumentor\Reflection\Types\Mixed_: mixed /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:105 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:158 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:124 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:73 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:141 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:122 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:73 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:138 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeClassDefinitionFactory.php:61 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:256 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:80 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeParser.php:53 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/SerdeTypeLookupFactory.php:25 /home/psc/projects/wiremock-php/src/WireMock/SerdeGen/WireMockSerdeGen.php:57 /home/psc/projects/wiremock-php/test/WireMock/SerdeGen/WireMockSerdeGenTest.php:18 /home/psc/projects/wiremock-php/test/WireMock/HamcrestTestCase.php:17 phpvfscomposer:///home/psc/projects/wiremock-php/vendor/phpunit/phpunit/phpunit:97

pscheit · 2025-06-24T18:48:03Z

src/WireMock/Client/XPathValueMatchingStrategy.php

-    /**
-     * @var string|AdvancedPathPattern
-     * @serde-named-by matchingType
-     * @serde-possible-names matchingValueNames
-     */
-    protected $matchingValue;


the property is defined in the ValueMatchingStrategy, can I delete them without breaking Serde?

pscheit · 2025-06-24T18:49:31Z

src/WireMock/Client/WireMock.php

        }

-        $requestPattern = $patternBuilder->build();
+        $requestPattern = $patternBuilder->build(); // @phpstan-ignore method.nonObject (@TODO this looks like an actual bug to me?)


so this looks like a bug to me.

if its an int then $pattnerBuilder is $requestPatternBuilder;

but this can be null and is not checked here? before its called.

pscheit · 2025-06-24T18:50:21Z

src/WireMock/Client/LoggedRequest.php

this class did not had an constructor, does Serde handle this?

rowanhill · 2025-08-26T09:52:50Z

Hello! Sorry for the super long delay. This turned into something much larger than I was expecting, and to be honest I don't have the time to dig into this to give the kind of response it needs.

Do you think there's a route to a much, much smaller change (e.g. just typing a few key public methods)? If not, I'm afraid I think we should abandon this approach...

pscheit · 2025-09-08T13:20:20Z

Yeah, its always like this, if you start without phpstan its really hard to get started with it.

But wanted to test the waters first, before diving into it entirely.

Of course we can

install phpstan
build a phpstan-baseline.neon
try to separate into different chunks and do much smaller PRS

but given the time it took to write a review comment and you saying:

and to be honest I don't have the time to dig into this to give the kind of response it needs.

I wouldn't pursue this either.

pscheit added 8 commits June 24, 2025 14:45

bump version to php 7.4

82b4915

install phpstan 2.x, configure

e8482d9

create simple justfile

f080cba

keep it simple and go level 8 and exclude the test folder for now, ca…

e2e116b

…use we have a lot errors

add a group to all integration tests to better selection with phpunit

a4352ae

use php7.4 locally in justfile

264afcf

throw a better exception when Serde cannot serialize a property becau…

d1775c3

…se of mixed types

try to fix all phpstan errors and baseline the rest (especially entir…

801b094

…e test + and src/WireMock/SerDe and src/WireMock/SerdeGen) Now unit tests are broken, because I added a lot of "mixed" property types, that are not supported by the Deserialization library.

pscheit mentioned this pull request Jun 24, 2025

Missing typhints for nearly everything #23

Open

pscheit commented Jun 24, 2025

View reviewed changes

config/phpstan/Hamcrest/AnyOf.stub

Copy link

Author

pscheit Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my next Project is then to type Hamcrest ;)

pscheit commented Jun 24, 2025

View reviewed changes

src/WireMock/Client/LoggedRequest.php

Copy link

Author

pscheit Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class did not had an constructor, does Serde handle this?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: Add missing property types#24

Draft: Add missing property types#24
pscheit wants to merge 8 commits intorowanhill:masterfrom
pscheit:add-missing-property-types

pscheit commented Jun 24, 2025 •

edited

Loading

Uh oh!

pscheit Jun 24, 2025

Uh oh!

pscheit Jun 24, 2025

Uh oh!

pscheit Jun 24, 2025

Uh oh!

pscheit Jun 24, 2025

Uh oh!

pscheit Jun 24, 2025

Uh oh!

pscheit Jun 24, 2025

Uh oh!

rowanhill commented Aug 26, 2025

Uh oh!

pscheit commented Sep 8, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

pscheit commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

pscheit Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

rowanhill commented Aug 26, 2025

Uh oh!

pscheit commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

pscheit commented Jun 24, 2025 •

edited

Loading

pscheit commented Sep 8, 2025 •

edited

Loading