Support PHP 8.5, remove deprecation#27
Open
jworreth wants to merge 2 commits intorowanhill:masterfrom
Open
Conversation
- curl_close is not needed anymore, for more detail, please refer to: https://www.php.net/manual/en/function.curl-close.php
jworreth
force-pushed
the
feature/php-8.5
branch
2 times, most recently
from
6806e8d to
4f709da
Compare
- Remove the usage of ReflectionProperty#setAccesible as it has no effect since PHP 8.1
jworreth
force-pushed
the
feature/php-8.5
branch
from
4f709da to
40de85f
Compare
Contributor
Author
|
There is still a deprecation warning regarding the method This method has no effect since PHP 8.1. The check is required as long as the package needs to be compatible with PHP<8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to PHP 8.5 makes wiremock not happy with
curl_closeas it has been deprecated.Please refer to: https://www.php.net/manual/en/function.curl-close.php