Skip to content

Conversation

@chenjiahan
Copy link
Member

Improving the error handling output by including the stack trace in the error string when available and standardizing string quotes.

Copilot AI review requested due to automatic review settings January 22, 2026 05:44
@gemini-code-assist
Copy link

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the error handling output for the html-rspack-plugin by incorporating stack traces into error messages, which will greatly assist in diagnosing issues. Concurrently, it addresses code style by enforcing the use of single quotes for string literals, contributing to a more uniform codebase.

Highlights

  • Enhanced Error Reporting: The error handling mechanism has been improved to include the full stack trace in error messages, providing more detailed debugging information.
  • Code Style Standardization: String literals within the lib/errors.js file have been standardized to use single quotes for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chenjiahan chenjiahan merged commit fd4599d into main Jan 22, 2026
7 checks passed
@chenjiahan chenjiahan deleted the error_stack_0122 branch January 22, 2026 05:45
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error reporting by including the stack trace in the output, which is very helpful for debugging. It also standardizes the use of single quotes for strings. I've suggested a small improvement to the error handling logic to make it more robust for cases where an error-like object might not have all the properties of a standard Error object.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves error handling output by adding stack traces to error messages and standardizes quote usage from double to single quotes throughout the errors module.

Changes:

  • Added stack trace support to error output (with fallback to formatted error name and message)
  • Standardized string quotes from double to single quotes
  • Added trailing comma for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants