-
Notifications
You must be signed in to change notification settings - Fork 42
chore(rstest): bump Rstest to 0.8.0 #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fi3ework, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Rstest testing framework to its latest Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps Rstest to version 0.8.0 and updates the necessary configurations and scripts. The changes look good. I've made one suggestion to improve consistency in dependency versioning. Additionally, I noticed you've updated the test script from rstest run to rstest in some packages. To maintain consistency across the monorepo, it would be beneficial to apply this change to other packages that still use the rstest run command.
| "@rsbuild/core": "^1.7.2", | ||
| "@rsbuild/plugin-react": "^1.4.3", | ||
| "@rstest/core": "0.7.9", | ||
| "@rstest/core": "0.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the other packages in this monorepo, consider using a caret ^ for this dependency's version. This allows for non-breaking patch and minor updates automatically. Most other package.json files in this project use a caret version for @rstest/core.
| "@rstest/core": "0.8.0", | |
| "@rstest/core": "^0.8.0", |
bump Rstest to 0.8.0.