Open
Conversation
Changed ifNotFloat to create an error in case the string cannot be parsed to a float. Previously it was creating the error if the string could be parsed to a float.
Correct ifNotFloat
|
any update on this? |
|
|
Author
|
Yes the logic is inverted, that is why I tried to submit this merge request. |
|
Thanks, I'm new too, I'm assuming your commit works so I'm going to simply copy the contents of Validate.elm with your fix and see if I can get things working. |
|
Tested it and it works, thanks. I guess this is a good argument for automated tests |
|
I spent the last hour staring at my code to figure out what was going wrong and then it was this 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed ifNotFloat to create an error in case it could not be parsed to a float.
Previously it was creating the error in case it could be parsed to a float.