fix(analytics): truncate gain history on char boundaries#2324
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2318.
Summary
rtk gain --historytruncated long command strings with a fixed byte slice (&cmd[..22]). When a command contained CJK filenames, byte 22 could land inside a multi-byte UTF-8 character and panic.This reuses the existing character-count-based
core::utils::truncatehelper for gain history command display and adds a regression test with the CJK filename shape from the issue.Validation
cargo fmt --checkcargo test analytics::gain::tests::truncate_history_command_handles_cjk_filenamescargo test analytics::gaincargo clippy --all-targets -- -D warningscargo test-> 2073 passed, 7 ignoredgit diff --check