fix(git): preserve merge commits in log output#2328
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2305.
Summary
--no-mergesto defaultrtk git loginvocations--onelineWhy
rtk git logpreviously injected--no-mergeswhenever the user did not pass an explicit count, which made merge commits invisible in common verification commands likertk git log --oneline. Merge commits can beHEAD, so hiding them changes normalgit logsemantics and breaks merge/PR verification.Validation
cargo fmt --checkcargo test cmds::git::git::tests::test_configure_log_command_preserves_merge_commitscargo test cmds::git::git::testscargo clippy --all-targets -- -D warningscargo test(2147 passed, 8 ignored)git log --onelineandrtk git log --onelineboth listed the merge commit first.