fix: handle tail rewrites with read tail-lines#412
Open
gula00 wants to merge 1 commit intortk-ai:masterfrom
Open
fix: handle tail rewrites with read tail-lines#412gula00 wants to merge 1 commit intortk-ai:masterfrom
gula00 wants to merge 1 commit intortk-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407
Summary
This PR fixes the
tail -Nrewrite regression where:rtk rewrite "tail -20 <file>"incorrectly producedrtk read -20 <file>rtk readdoes not accept that flag formatWhat changed
Added tail-specific rewrite handling in
src/discover/registry.rs:tail -N <file>->rtk read <file> --tail-lines Ntail -n N <file>->rtk read <file> --tail-lines Ntail --lines=N <file>->rtk read <file> --tail-lines Ntail --lines N <file>->rtk read <file> --tail-lines NAdded
--tail-linessupport tortk readin:src/main.rssrc/read.rsMade
--tail-linesand--max-linesmutually exclusiveKept unsupported
tailforms (e.g.tail -c) as no-rewrite fallback for safetyValidation
Added unit tests for rewrite mappings and read tail behavior
Ran:
cargo fmt --allcargo clippy --all-targetscargo test --all