Skip to content

fix: preserve gh run view passthrough args#419

Open
tsubasakong wants to merge 1 commit intortk-ai:developfrom
tsubasakong:lucas/issue-416-gh-run-view-job
Open

fix: preserve gh run view passthrough args#419
tsubasakong wants to merge 1 commit intortk-ai:developfrom
tsubasakong:lucas/issue-416-gh-run-view-job

Conversation

@tsubasakong
Copy link

@tsubasakong tsubasakong commented Mar 8, 2026

Summary

  • preserve raw passthrough for flag-only forms like gh run view --log-failed --job <job-id> by checking passthrough flags before extracting a positional run ID
  • treat short -j / -a forms the same as --job / --attempt when parsing gh run view arguments
  • add regression tests covering short-flag and flag-only argument combinations

Fixes #416.

Validation

  • cargo fmt --all --check
  • cargo clippy --all-targets
  • cargo test

Copy link

@saimonmoore saimonmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks a lot!

@pszymkowiak
Copy link
Collaborator

Hi! Thanks for the contribution! Since March 6, all PRs should target the develop branch instead of master (see CONTRIBUTING.md).

Could you update the base branch? Click Edit at the top right of this PR and change it from master to develop.

Thanks!

Signed-off-by: Frank <97429702+tsubasakong@users.noreply.github.com>
@tsubasakong tsubasakong force-pushed the lucas/issue-416-gh-run-view-job branch from 70ab058 to b9442b4 Compare March 12, 2026 03:55
@tsubasakong tsubasakong changed the base branch from master to develop March 12, 2026 03:55
@tsubasakong
Copy link
Author

Updated this PR to target develop and rebuilt it on top of current develop. The remaining diff is now just the passthrough-order + short-flag (-j / -a) fix, with local cargo fmt --all --check, cargo clippy --all-targets, and cargo test all passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue accepting arguments for gh run

3 participants