fix: preserve gh run view passthrough args#419
Open
tsubasakong wants to merge 1 commit intortk-ai:developfrom
Open
fix: preserve gh run view passthrough args#419tsubasakong wants to merge 1 commit intortk-ai:developfrom
tsubasakong wants to merge 1 commit intortk-ai:developfrom
Conversation
Collaborator
|
Hi! Thanks for the contribution! Since March 6, all PRs should target the Could you update the base branch? Click Edit at the top right of this PR and change it from Thanks! |
Signed-off-by: Frank <97429702+tsubasakong@users.noreply.github.com>
70ab058 to
b9442b4
Compare
Author
|
Updated this PR to target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh run view --log-failed --job <job-id>by checking passthrough flags before extracting a positional run ID-j/-aforms the same as--job/--attemptwhen parsinggh run viewargumentsFixes #416.
Validation
cargo fmt --all --checkcargo clippy --all-targetscargo test