fix: resolve cargo fmt + 54 clippy warnings blocking CI#663
Merged
pszymkowiak merged 1 commit intodevelopfrom Mar 17, 2026
Merged
fix: resolve cargo fmt + 54 clippy warnings blocking CI#663pszymkowiak merged 1 commit intodevelopfrom
pszymkowiak merged 1 commit intodevelopfrom
Conversation
cargo fmt diffs in config.rs, git.rs, playwright_cmd.rs were failing the fmt CI check, which cascaded to block clippy/test/security on PRs #632, #635, #638. Also fixes all clippy warnings: dead code annotations, iterator simplifications, assert patterns, and unnecessary allocations. Signed-off-by: Patrick Szymkowiak <patrick@rtk-ai.app> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
ahundt
added a commit
to ahundt/rtk
that referenced
this pull request
Mar 18, 2026
Merge 34 upstream commits (develop) including: - src/trust.rs: trust boundary for project-local TOML filters - src/git.rs: git log --oneline regression fix (user_format 4th param) - src/git.rs: nothing-to-commit detection in commit handler - 6 critical bug fixes: exit codes, unwrap, lazy regex (rtk-ai#626) - src/discover/registry.rs: find/fd pipe-skip ported to token-based lexer - cargo fmt + 54 clippy warnings fix (rtk-ai#663) - subcommand routing fix (rtk-ai#600), output cap raise (rtk-ai#617-620) - SQLite WAL, grep regex perf (rtk-ai#631) Conflict resolution (6 files, 11 hunks): - src/main.rs: kept Pipe (ours) + Trust/Untrust (upstream) - src/git.rs: pub(crate) (ours) + user_format param (upstream) - src/grep_cmd.rs: filter_grep_raw (ours) + context_re (upstream) - src/init.rs: remove-then-insert upgrade path (ours) - src/tracking.rs: merged doc comments - src/discover/registry.rs: token-based lexer (ours) + find/fd skip (upstream) - src/tee.rs: removed duplicate derive(Default) - src/pipe_cmd.rs: added user_format=false 4th arg Tests: 1388 passed (was 1358), 0 failures, 6 ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmtdiffs in config.rs, git.rs, playwright_cmd.rs that were failing the fmt CI checkTest plan
cargo fmt --all --check— cleancargo clippy --all-targets -- -D warnings— 0 warningscargo test --all— 934 passed, 0 failed