Fix: MSH offset on array getters and setters#141
Fix: MSH offset on array getters and setters#141LucasMontorio wants to merge 2 commits intomasterfrom
Conversation
…nd #[]= methods to respect the order of fields
|
Rubocop is failing. |
9e3b226 to
e05ac89
Compare
Thanks, it's fixed |
Hi @Stratus3D, is there anything else blocking in the PR according to you? :) |
Stratus3D
left a comment
There was a problem hiding this comment.
Not sure I understate the index offset logic. I don't have time to put into this project, so I'll leave this PR up to you. I'd be nice if one of the other old maintainers could weight in on PRs like this.
I'll keep it open at least until the preparation of the next version bump, in hope for another review. Thanks for checking it anyway |
Description
Fixes #123
The MSH-1 field has a special behaviour, and does not appear in the output of the HL7 string for this segment, hence breaking the indexing of the other fields by causing an offset.
This PR fixes the offset and restores the order of indexes as expected.
Checklist