Skip to content

Include the trailing ? in a keyword key's symbol location #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 1 commit into from
Jul 29, 2026
+6 −3
Merged

Include the trailing ? in a keyword key's symbol location #3043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,18 +405,21 @@ NODISCARD
static bool parse_keyword_key(rbs_parser_t *parser, rbs_ast_symbol_t **key) {
rbs_parser_advance(parser);

rbs_location_range symbol_range = rbs_location_range_current_token(parser);
rbs_range_t symbol_range = parser->current_token.range;

if (parser->next_token.type == pQUESTION) {
// The `?` is part of the key, so it is part of the location too.
symbol_range.end = parser->next_token.range.end;

*key = rbs_ast_symbol_new(
ALLOCATOR(),
symbol_range,
RBS_RANGE_LEX2AST(symbol_range),
&parser->constant_pool,
intern_token_start_end(parser, parser->current_token, parser->next_token)
);
rbs_parser_advance(parser);
} else {
*key = rbs_ast_symbol_new(ALLOCATOR(), symbol_range, &parser->constant_pool, INTERN_TOKEN(parser, parser->current_token));
*key = rbs_ast_symbol_new(ALLOCATOR(), RBS_RANGE_LEX2AST(symbol_range), &parser->constant_pool, INTERN_TOKEN(parser, parser->current_token));
}

return true;
Expand Down
Loading