fix(ruby-wasm): make Node able to load ruby+stdlib.wasm from dist/#593
Merged
kateinoigakukun merged 1 commit intoruby:mainfrom Apr 20, 2025
Merged
fix(ruby-wasm): make Node able to load ruby+stdlib.wasm from dist/#593kateinoigakukun merged 1 commit intoruby:mainfrom
kateinoigakukun merged 1 commit intoruby:mainfrom
Conversation
- package.json
- change `exports` to `"./dist/*.wasm": { "import": "./dist/*.wasm",
"require": "./dist/*.wasm" }`
so sub‑path imports like `@ruby/3.x-wasm-wasi/dist/ruby+stdlib.wasm`
resolve correctly.
Contributor
Author
|
@kateinoigakukun Excuse me, I forget the patch for head packages. Please add them to head packages. |
Member
|
Applied 8a49b71 |
Contributor
Author
|
Thanks ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Thank you for the great project. I change
exportsto"./dist/*.wasm": { "import": "./dist/*.wasm", "require": "./dist/*.wasm" }so sub‑path imports like@ruby/3.x-wasm-wasi/dist/ruby+stdlib.wasmresolve correctly.