Theme payments index page#1581
Open
maebeale wants to merge 2 commits into
Open
Conversation
- Restyle the payments index to match the app shell: DomainTheme-tinted container, sentence-case headings/buttons, and a wider max-width layout. - Vite watches app/views/**/* so ERB-driven Tailwind classes rebuild in dev. Note: the page tints via DomainTheme.bg_class_for(:payments); the :payments key is added in the event dashboard PR (#1578) and falls back to gray until that merges. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PaymentPolicy is empty, so index? resolves through ApplicationPolicy to admin?, making the page admin-only rather than admin-or-auth. Correct the bg class and track the view in the alignment spec's EXPECTED_MAPPINGS so the "every view accounted for" guard passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
payments/indexto the standard shell: aDomainTheme-tinted rounded container, widermax-w-7xllayout, and sentence-case headings/buttons ("Add cash payment" / "Add check payment").app/views/**/*so ERB-driven Tailwind classes rebuild during development.Anything else to add?
DomainTheme.bg_class_for(:payments). The:paymentskey is introduced in the event dashboard PR (Theme event dashboard cards and count only allocated scholarships #1578); until that merges, this falls back to a neutral gray. Merge Theme event dashboard cards and count only allocated scholarships #1578 first (or we can add the key here) for the green tint.🤖 Generated with Claude Code