-
-
Notifications
You must be signed in to change notification settings - Fork 572
4948 - Fixing the sorting issues within parts of the app - part 1 of X #5299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kellis5137
wants to merge
9
commits into
rubyforgood:main
Choose a base branch
from
kellis5137:4948-fix-sort-issues-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−1
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0999e16
Adding resource_id sort fix and test
kellis5137 5de4794
Fixed use of ids to be able to pass tests anywhere.
kellis5137 68369c5
Merge branch 'main' into 4948-fix-sort-issues-1
kellis5137 7735d10
Merge branch 'rubyforgood:main' into 4948-fix-sort-issues-1
kellis5137 94b5f3e
Modified to work for Postgres and not MySQL :-)
kellis5137 81b68ef
Moved and cleaned up rspec
kellis5137 5128dec
fixing lint issue
kellis5137 cb70bad
Replace regex rspec test.
kellis5137 7504de0
Merge branch 'main' into 4948-fix-sort-issues-1
awwaiid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -167,4 +167,24 @@ | |
| end | ||
| end | ||
| end | ||
|
|
||
| describe "Resourse Dropdown List: Validate Order" do | ||
| before do | ||
| sign_in(super_admin) | ||
| end | ||
|
|
||
| it "Should sort display resource in human alphabetical order" do | ||
| FactoryBot.create(:organization, id: 2, name: "Pawnee") | ||
| FactoryBot.create(:organization, id: 3, name: "SF Diaper") | ||
| FactoryBot.create(:organization, id: 4, name: "Second City") | ||
|
|
||
| # params | ||
| # - resource_type - Organization, Resource | ||
| # - q - query string | ||
| # visit admin_users_resource_ids_path # (name: "Organization", q: "") | ||
|
||
|
|
||
| visit "/admin/users/resource_ids?resource_type=org_admin" | ||
| expect(page).to have_content("{\"id\":2,\"text\":\"Pawnee\"},{\"id\":4,\"text\":\"Second City\"},{\"id\":3,\"text\":\"SF Diaper\"}") | ||
| end | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to a request spec? System specs are slow and flaky and should only be used if there needs to be browser / JavaScript interaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorner Take a look now and let me know if that looks better