test: first working test run #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR establishes the initial test infrastructure by replacing the basic test setup with a more comprehensive test helper configuration and fixing a critical path reference error.
- Replaces
test/test_helper.rbwithtest/helper.rbthat includes coverage tools, WebMock configuration, and test setup - Fixes incorrect require path from
domeapi/versiontokalshi/versioninlib/kalshi.rb - Updates Rake test task configuration to use
Rake::TestTaskinstead ofMinitest::TestTask
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_helper.rb | Removed legacy test helper |
| test/kalshi/test_rb.rb | Updated to require new 'helper' and removed placeholder test |
| test/helper.rb | Added comprehensive test helper with SimpleCov, WebMock, and Minitest configuration |
| lib/kalshi.rb | Fixed require path from 'domeapi/version' to 'kalshi/version' |
| Rakefile | Switched from Minitest::TestTask to Rake::TestTask with custom configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.