Fix-up test suite#43
Draft
heythisisnate wants to merge 1 commit into
Draft
Conversation
Collaborator
|
@heythisisnate Give me a week or two. Going to try to get some time for it then. Sorry. Just a little busy at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is still a WIP ...
It seems like the tests/spec suite is egregiously out of date. I started poking at it to at least try to get the specs running again so I can add some tests for my recent PRs #42 and #43, and they do run now, albeit with lots of failures. I kinda paused here for now, because it seems like a big task.
Apparently the test suite requires the following DynamoDB tables to be created, although there is no migration or equivalent of a
db:test:preparetask to create them. It looks like in the past there has been some attempt at mocking and stubbing the actual calls to DynamoDB although that's not actually working 100% and it's still going thru to the database.With these tables added to dynamodb-local the tests do run locally.
This is in no way a criticism of @tongueroo's amazing work on this gem -- believe me I've been there too. Sometimes you just wanna get stuff working and updating the test suite is a burden.
I would like to get the tests back on-par with reality so I can confidently make some tweaks to the gem. @tongueroo are you open to a quick chat about this soon?