desktop: Only attach to parent console on Windows if stdout is not a pipe or a regular file #22557
+68
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-desktop
Contributor
|
This checks out per my testing. I'd say it's good to merge. |
kjarosh
reviewed
Dec 22, 2025
SuchAFuriousDeath
force-pushed
the
windows-console-fix
branch
from
f29cb3d to
ed4f1e6
Compare
kjarosh
reviewed
Dec 22, 2025
SuchAFuriousDeath
force-pushed
the
windows-console-fix
branch
3 times, most recently
from
25d4497 to
d887212
Compare
kjarosh
approved these changes
Dec 23, 2025
SuchAFuriousDeath
force-pushed
the
windows-console-fix
branch
from
d887212 to
32279b1
Compare
…pipe or a regular file
SuchAFuriousDeath
force-pushed
the
windows-console-fix
branch
from
32279b1 to
48cd327
Compare
kjarosh
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9145. I tested this on my Windows backup laptop and it seems to work, but somebody please double check.
The original code caused the issue by attaching to a console unconditionally, which overrode the redirection to the file.