desktop: Improve, update and correct Windows metadata by SuchAFuriousDeath · Pull Request #22769 · ruffle-rs/ruffle

SuchAFuriousDeath · 2026-01-15T12:35:52Z

Split off from #17488

This also implements the debug flag todo from the removed ruffle_desktop.rc and includes some minor refactors.

Not sure why, but CompanyName isn't displayed now and it wasn't even displayed before

Before:

After:

kjarosh · 2026-01-15T15:28:45Z

Where is the version being set and what about nightly releases?

SuchAFuriousDeath · 2026-01-15T15:29:17Z

The version is being taken from Cargo.toml, right now it's still 0.1.0 I think

kjarosh · 2026-01-15T15:30:04Z

What about the other version?

SuchAFuriousDeath · 2026-01-15T15:31:32Z

What other version? 😅 As for nightly, nothing special happens right now although I agree it would be reasonable to integrate it somehow.

kjarosh · 2026-01-15T15:36:22Z

What other version?

There are two versions on your screens, one has 4 parts.

As for nightly, nothing special happens right now although I agree it would be reasonable to integrate it somehow.

And I think that's how it should be. In general try not to change semver, unless something literally does not support it, in which case we can think about transforming the version.

SuchAFuriousDeath · 2026-01-15T15:37:26Z

The other version means 'file version' and I don't know what it's for, I'll research it.

SuchAFuriousDeath · 2026-01-15T15:39:15Z

Per https://learn.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block:

Version number of the file—for example, "3.10" or "5.00.RC2". This string is required.

I don't get it tbf 😅

SuchAFuriousDeath · 2026-01-15T15:41:37Z

Ok actually I think I do get it now. ProductVersion is the version of the overall product and FileVersion is the version of that particular file. I guess for us they should always be the same, since it's just 1 .exe file.

kjarosh · 2026-01-15T15:44:41Z

Ok actually I think I do get it now. ProductVersion is the version of the overall product and FileVersion is the version of that particular file. I guess for us they should always be the same, since it's just 1 .exe file.

Looks like a downstream version. The question is whether it's standalone or dependent on product version.

Imagine a distribution of Ruffle, they will have their own compile scripts, etc. In which case from the same version of the product, you can create different binaries. Maybe the version should be always equal to 1 then?

SuchAFuriousDeath · 2026-01-15T15:57:42Z

I think it's mainly for when you have multiple files that are both part of one product.

SuchAFuriousDeath · 2026-01-15T16:31:04Z

Btw probably focus on my other PRs first, they are more consequential than this one 😅

SuchAFuriousDeath · 2026-01-16T08:56:35Z

Now we just have to settle on what to do about the versions.

SuchAFuriousDeath · 2026-01-23T17:02:40Z

@kjarosh BenjaminRi/winresource#46 was merged and released as v0.1.30 and I used the new flag in the code, so this can be merged now.

Co-authored-by: Tomáš Procházka <SuchAFuriousDeath@users.noreply.github.com>

@RipleyTom

------------------------------------------------------------------------------------- azahar.mk 0a705b74492cc4bd05bb9194fb330017b08c0df9 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------- Updated translations via Transifex, ------------------------------------------------------------------------------------------ dolphin-emu.mk cdbea8867df3d0a6fc375e78726dae95612fb1fd # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------------ Merge pull request #14225 from matellush/master Flatpak: Update runtime to `6.10`, ------------------------------------------------------------------------------------------ duckstation.mk 1379d3ae5555f4f3567bceba1c6f7356c157ef09 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------------ Qt: Fix recommended value for Optimal Frame Pacing, --------------------------------------------------- pcsx2.mk v2.7.62 # Version: Commits on Jan 24, 2026 --------------------------------------------------- - [GS: Default to DX12 on NV/AMD.](PCSX2/pcsx2#13877) , ------------------------------------------------------------------------------------ rpcs3.mk f883718b238e6897635201a67ca11537ce197510 # Version: Commits on Jan 24, 2026 ------------------------------------------------------------------------------------ USB: Complete Summonride figures - Support the last 3 riders discovered by @RipleyTom - Simplify the creator dialog, ------------------------------------------------------------------------------------- ikemen.mk 1a65f00557331dba97ca6037624fe0acc19be323 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------- Merge pull request #3184 from ikemen-engine/fix7 refactor: simplify demo.zss, --------------------------------------------------------------- ruffle.mk nightly-2026-01-25 # Version: Commits on Jan 25, 2026 --------------------------------------------------------------- ## What's Changed * desktop: Improve, update and correct Windows metadata by @SuchAFuriousDeath in ruffle-rs/ruffle#22769 * avm2: Handle invalid ShaderData parameter assignments by @SuchAFuriousDeath in ruffle-rs/ruffle#22679 * avm2: Throw Error #1052 on invalid UTF-16 surrogates in encodeURI and encodeURIComponent by @SuchAFuriousDeath in ruffle-rs/ruffle#22831 * wgpu: Unify wgpu instance creation by @SuchAFuriousDeath in ruffle-rs/ruffle#22720 **Full Changelog**: ruffle-rs/ruffle@nightly-2026-01-24...nightly-2026-01-25, ----------------------------------------------------------------------------------------- sdl3_mixer.mk 2326c7393cef840d2aec9074bbf1f98a60ff103b # Version: Commits on Jan 24, 2026 ----------------------------------------------------------------------------------------- examples: Added basic examples! Reference Issue #807., ------------------------------------------------------------------------------------ box64.mk be35201c653b829c9ed64cced07e417cf0d25593 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------ [BOX32] Removed redundant logging prefix (#3407), ------------------------------------------------------------------------------------------ devilutionx.mk f4b9fd904c77dbbad687fb707bf33739b1d0b962 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------------ Reposition Windows MSVC x64 badge in README, ------------------------------------------------------------------------------------------ dxx-rebirth.mk 51726f3c82763ced293e204494fa22376e9e787b # Version: Commits on Jan 24, 2026 ------------------------------------------------------------------------------------------ `collide_weapon_and_weapon`: cache Weapon_info[].destroyable flag These flags cannot change during the course of the function, so cache them at first lookup., --------------------------------------------------------------------------------------- etlegacy.mk ded311cbf494381dc172624a85db76fd4fe4b541 # Version: Commits on Jan 24, 2026 --------------------------------------------------------------------------------------- cgame: refactor get selected tab into function, ------------------------------------------------------------------------------------------ fallout2-ce.mk 3249b7dc0779bae8294da796133c2a7264fbdf10 # Version: Commits on Jan 25, 2026 ------------------------------------------------------------------------------------------ Merge pull request #276 from fallout2-ce/improvements_for_map_edge Disable hi-res stencil if ignoreMapEdges is enabled, ---------------------------------------------------------------------------------------- supertux2.mk ceb278645daae6de0750bac4ea566f263bcae4ed # Version: Commits on Jan 24, 2026 ---------------------------------------------------------------------------------------- world1: unglint snowball falling in spikes [ci skip], ---------------------------------------------------------------------------------------------------- sdl2-gamecontrollerdb.mk 319385d7e4394ab28253f14294b7d7dbf1331ec0 # Version: Commits on Jan 25, 2026 ---------------------------------------------------------------------------------------------------- Clean up Xbox 360 Linux mappigs, ---------------------------------------------------------------------------------------- retroarch.mk a458d7e748c6f42b0b6ac8b5a21d06a045f71fa9 # Version: Commits on Jan 25, 2026 ---------------------------------------------------------------------------------------- Fetch translations from Crowdin, ---------------------------------------------------------------------------------------- doomretro.mk c035207da8b070542e0f4848b3adecdbbd0e42fe # Version: Commits on Jan 25, 2026 ---------------------------------------------------------------------------------------- Handle obituaries for crushed monsters better, -------------------------------------------------------------------------------------- yquake2.mk d9f5a3e38eb09300ae0556a524f5cf898fbbe012 # Version: Commits on Jan 24, 2026 -------------------------------------------------------------------------------------- refresh: render could cleanup alias model cache record, ----------------------------------------------------------------------------------------- sonic3-air.mk 298f2f3adba6c66aabc1b23bc5bee901c5e99050 # Version: Commits on Jan 24, 2026 ----------------------------------------------------------------------------------------- Minor code refinements by using is / as / cast helper functions is various more cases, ---------------------------------------------------------------------------------- trx.mk d7bd98819b74fdd1908fb8fcd947ecdc49d7307e # Version: Commits on Jan 24, 2026 ---------------------------------------------------------------------------------- catalog: support remaining catalogs,

kjarosh reviewed Jan 15, 2026

View reviewed changes

Comment thread desktop/build.rs Outdated

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch from a6bd12a to ed7cf2e Compare January 15, 2026 16:11

SuchAFuriousDeath requested a review from kjarosh January 15, 2026 16:12

kjarosh added A-desktop Area: Desktop Application windows Windows-specific issues T-feature Type: New Feature (that Flash doesn't have) labels Jan 15, 2026

kjarosh reviewed Jan 16, 2026

View reviewed changes

Comment thread desktop/build.rs Outdated

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch from ed7cf2e to 8494742 Compare January 16, 2026 08:54

SuchAFuriousDeath requested a review from kjarosh January 16, 2026 08:56

kjarosh reviewed Jan 18, 2026

View reviewed changes

Comment thread desktop/build.rs Outdated

kjarosh reviewed Jan 18, 2026

View reviewed changes

Comment thread desktop/build.rs Outdated

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch 2 times, most recently from 89d4ddf to bda47b2 Compare January 18, 2026 15:09

SuchAFuriousDeath requested a review from kjarosh January 18, 2026 15:10

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch from bda47b2 to 9f0a415 Compare January 19, 2026 09:14

kjarosh reviewed Jan 19, 2026

View reviewed changes

Comment thread desktop/Cargo.toml Outdated

Comment thread desktop/build.rs Outdated

Comment thread desktop/build.rs Outdated

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch from 9f0a415 to 97bab07 Compare January 19, 2026 15:47

SuchAFuriousDeath requested a review from kjarosh January 19, 2026 15:47

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch 3 times, most recently from a83c72b to 7431622 Compare January 20, 2026 11:01

SuchAFuriousDeath mentioned this pull request Jan 20, 2026

Add VS_FF_* file flags constants BenjaminRi/winresource#46

Merged

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch 3 times, most recently from 8ca833b to e5505f6 Compare January 20, 2026 23:22

kjarosh reviewed Jan 21, 2026

View reviewed changes

Comment thread core/src/display_object/edit_text.rs Outdated

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch 2 times, most recently from 3c8b926 to 3b0de7f Compare January 23, 2026 17:01

SuchAFuriousDeath requested a review from kjarosh January 23, 2026 17:02

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch 2 times, most recently from af2d291 to 8d83997 Compare January 23, 2026 23:56

desktop: Improve, update and correct Windows metadata

f85035b

Co-authored-by: Tomáš Procházka <SuchAFuriousDeath@users.noreply.github.com>

SuchAFuriousDeath force-pushed the windows-desktop-metadata branch from 8d83997 to f85035b Compare January 24, 2026 00:08

kjarosh approved these changes Jan 24, 2026

View reviewed changes

kjarosh merged commit ec7b7e8 into ruffle-rs:master Jan 24, 2026
26 checks passed

SuchAFuriousDeath deleted the windows-desktop-metadata branch January 24, 2026 01:07

Uh oh!

Conversation

SuchAFuriousDeath commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kjarosh commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

kjarosh commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

kjarosh commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

kjarosh commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

SuchAFuriousDeath commented Jan 15, 2026

Uh oh!

Uh oh!

SuchAFuriousDeath commented Jan 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuchAFuriousDeath commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SuchAFuriousDeath commented Jan 15, 2026 •

edited

Loading

SuchAFuriousDeath commented Jan 15, 2026 •

edited

Loading