Skip to content

Conversation

@gacevedo
Copy link

@gacevedo gacevedo commented Jan 3, 2026

Intercept mailto: links and open a compose window. Fixes issue #939.

@castaway
Copy link
Contributor

castaway commented Jan 5, 2026

@gacevedo Thanks for your PR! We need to update CONTRIBUTING, oops! These days npm run build will generate the changelog (and test it) for you. No need to commit it as our deployment script runs this again to generate the new changelog for a deployment.

Could you remove it from your PR please?

@gacevedo
Copy link
Author

gacevedo commented Jan 5, 2026

@gacevedo Thanks for your PR! We need to update CONTRIBUTING, oops! These days npm run build will generate the changelog (and test it) for you. No need to commit it as our deployment script runs this again to generate the new changelog for a deployment.

Could you remove it from your PR please?

@castaway Thank you for the clarification. The PR has been updated as requested.

@gacevedo
Copy link
Author

gacevedo commented Jan 6, 2026

@castaway I might need help defeating that Commitlint check. The documentation might be outdated or I'm not understanding something: https://github.com/runbox/runbox7/blob/master/CONTRIBUTING.md#revert.

If the commit reverts a previous commit, it should begin with revert:, followed by the header of the reverted commit. In the body it should say: This reverts commit ., where the hash is the SHA of the commit being reverted.

Please advise. Thank you!

@gacevedo
Copy link
Author

gacevedo commented Jan 7, 2026

@castaway I might need help defeating that Commitlint check. The documentation might be outdated or I'm not understanding something: https://github.com/runbox/runbox7/blob/master/CONTRIBUTING.md#revert.

If the commit reverts a previous commit, it should begin with revert:, followed by the header of the reverted commit. In the body it should say: This reverts commit ., where the hash is the SHA of the commit being reverted.

Please advise. Thank you!

Never mind. I just deleted the commit(s) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants