Merged
Conversation
…DGET_CLOSED, MAX_EXTENSIONS_EXCEEDED) The Java implementation and tests use these 3 error codes but they were missing from the YAML spec enum. This brings the spec in sync with the server implementation. https://claude.ai/code/session_01WeUFfwYKWvpCXPUYsZLqUa
The Java implementation returns a charged field when overage_policy is ALLOW_IF_AVAILABLE and the actual was capped. This was missing from the YAML spec (which also has additionalProperties: false, making it a strict violation). Adds the field to align spec with implementation. https://claude.ai/code/session_01WeUFfwYKWvpCXPUYsZLqUa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit Summary
Fix Applied
Protocol spec (
cycles-protocol/cycles-protocol-v0.yaml) — added 3 missingErrorCodevalues that were in the Java implementation but not the YAML spec:BUDGET_FROZEN— returned when operations target a frozen budgetBUDGET_CLOSED— returned when operations target a closed budgetMAX_EXTENSIONS_EXCEEDED— returned when a reservation hits its extension limitCommitted as
bf5c620and pushed toclaude/analyze-tenant-config-0ECd6.Everything Else Is Consistent
Test Results
The admin audit found 2 more discrepancies. Let me fix them.